Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arm64v8 Dockerfile #133

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Fix arm64v8 Dockerfile #133

merged 1 commit into from
Aug 7, 2021

Conversation

evroon
Copy link
Contributor

@evroon evroon commented Aug 7, 2021 •
edited by pull-request-badge bot
Loading

Quick evroon /fix-docker-arm64v8 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 evroon Powered by Pull Request Badge

Category:
Bugfix

Overview
Fixes Dockerfile-arm64v8.

Issue Number #117

Code Quality Checklist

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

@evroon evroon requested a review from Lissy93 as a code owner August 7, 2021 18:11
@netlify
Copy link

netlify bot commented Aug 7, 2021 •
edited
Loading

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 5728b59

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/610eccc8a4c0740008fd2534

😎 Browse the preview: https://deploy-preview-133--dashy-dev.netlify.app

@evroon evroon mentioned this pull request Aug 7, 2021
Closed
6 tasks
@Lissy93 Lissy93 merged commit 12adb90 into Lissy93:master Aug 7, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

Thanks so much, fingers crossed this will work :)

@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

If it doesn't work, I think I've just managed to get a version running using node:lts-alpine as the base and multiarch/qemu-user-static for the ARM 64 part. Looks like it's working on DockerHub, and the build time wasn't too long, but haven't yet tested it on my Pi

@evroon
Copy link
Contributor Author

evroon commented Aug 7, 2021

Ah the image is now on DockerHub.

@evroon evroon deleted the fix-docker-arm64v8 branch August 7, 2021 18:59
@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

Awesome, your fix is working!
This is amazing, I'm a proper noob at Docker, and spent ages yesterday trying to figure this out, so I'm super happy it's working now, you're really good at this, thanks so much for the PR's :) Your container is now live on Docker Hub, and all green
image

@evroon
Copy link
Contributor Author

evroon commented Aug 8, 2021

Haha no problem, I'm glad it's working. I wish I knew as much as you do about Vue.js etc. ;)

asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
@walkxcode
🍱 Adds Mojeek (Lissy93#133)
2650093 
Closes Lissy93#133

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evroon @Lissy93